Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sap_*_preconfigure: disable and stop sapconf when saptune run #640

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

Wabri
Copy link
Member

@Wabri Wabri commented Feb 6, 2024

Closes #333

@sean-freeman sean-freeman self-requested a review February 7, 2024 23:59
Copy link
Member

@sean-freeman sean-freeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@sean-freeman sean-freeman changed the title fix(roles/sap_*_preconfigure): disable and stop sapconf when saptune run sap_*_preconfigure: disable and stop sapconf when saptune run Feb 8, 2024
@Wabri
Copy link
Member Author

Wabri commented Feb 8, 2024

@sean-freeman Why the zuul ci gives errors? I cannot access to the logs

@sean-freeman
Copy link
Member

@Wabri I checked Zuul, I cannot access that job's log either because the error is itself related to the logs :) POST_FAILURE appears to mean, the container did not successfully upload the logs back to the CI/CD Pipeline host.

This particular job is a prerequisite for the auto-upload to Ansible Galaxy upon a release. The check is the same each time so, you can look at the job logs here from a different build run yesterday (after yours) that passed immediately. I tried to re-trigger for this PR, but this check is done via webhook so unless a bit of code is pushed into the PR - it won't trigger again.

Best to ignore it and merge if you're ready to do so IMHO. Your PR contents clearly wouldn't break this check.

@Wabri Wabri self-assigned this Feb 8, 2024
@Wabri
Copy link
Member Author

Wabri commented Feb 8, 2024

Lets ignore it then 💯

@Wabri Wabri merged commit 541ee07 into sap-linuxlab:dev Feb 8, 2024
3 of 4 checks passed
@Wabri Wabri deleted the feature/333/sles-saptune-check branch February 8, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants