Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sap_swpm: Add optional flag to prevent redoing ownership change #664

Closed
wants to merge 3 commits into from
Closed

Conversation

rnozaki
Copy link
Contributor

@rnozaki rnozaki commented Feb 22, 2024

This is a suggestion for issue #663

@berndfinger berndfinger self-requested a review February 27, 2024 10:04
@berndfinger
Copy link
Member

@rnozaki Thanks for the PR. I am currently working on a different solution, which would be:

  • Change the ownership to root:root and permissions of the directories only, and of all files with file names starting with SAPCAR, to 0755. Use a role parameter named sap_swpm_set_directory_sapcar_permissions to optionally skip this step.
  • Change the ownership to root:root and permissions of all files only, except SAPCAR to 0644. Use a role parameter named sap_swpm_set_file_permissions to optionally skip this step. If we find out during the testing phase that the permissions of the files have never been wrong, we can skip this step by default and use this role parameter to optionally enable this step.

What do you think about this?

@rnozaki
Copy link
Contributor Author

rnozaki commented Feb 28, 2024

Looks like a viable approach.

We just need to make sure that any ownership change that must be done, be done at least once (initially).

@berndfinger
Copy link
Member

We just need to make sure that any ownership change that must be done, be done at least once (initially).

@rnozaki Please have a look at #665 .

@rnozaki
Copy link
Contributor Author

rnozaki commented Mar 4, 2024

We just need to make sure that any ownership change that must be done, be done at least once (initially).

@rnozaki Please have a look at #665 .

Yes, that looks good, Bernd. That will cover what I requested in issue #663 .

When do you think this will be released?

@sean-freeman sean-freeman changed the base branch from main to dev March 7, 2024 22:17
@sean-freeman sean-freeman changed the title Add optional flag to prevent redoing ownership change sap_swpm: Add optional flag to prevent redoing ownership change Mar 7, 2024
@berndfinger
Copy link
Member

berndfinger commented Mar 8, 2024

When do you think this will be released?

Now ;-) (as part of dev)

@berndfinger berndfinger closed this Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants