-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sap_swpm: Remove pids module #720
Conversation
Signed-off-by: Bernd Finger <[email protected]>
Relates to sap-linuxlab#716 and sap-linuxlab#719. Signed-off-by: Bernd Finger <[email protected]>
Relates to sap-linuxlab#719. Signed-off-by: Bernd Finger <[email protected]>
Relates to sap-linuxlab#719. Signed-off-by: Bernd Finger <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@berndfinger Tested and it works for sap_swpm, but it breaks recent changes in sap_ha_pacemaker_cluster and ha_cluster roles.
New ASCS/ERS post steps were added that include python3-pip with pexpect for ansible.builtin.expect module in
community.sap_install/roles/sap_ha_pacemaker_cluster/tasks/Suse/post_steps_nwas_abap_ascs_ers.yml
Line 20 in ef06363
ansible.builtin.expect: |
@ja9fuchs We would need to take these removed python/pip steps and put them into sap_ha role instead.
@berndfinger did you figure out your issues that you mentioned? |
None of the issues I had seen were related to this code change but rather to wrong parameter settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Aborting PR due to an error when resolving a merge conflict. |
We should better remove the
community.general.pids
module. Advantages:community.general
in the role sap_swpm, simplifying support for downstream versionsSolves #719.