Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sap_swpm: Use 'false' instead of 'False' in inifile.params #916

Conversation

berndfinger
Copy link
Member

Fixes issue #915.

Copy link
Contributor

@ja9fuchs ja9fuchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me

@berndfinger berndfinger self-assigned this Dec 18, 2024
Copy link
Member

@sean-freeman sean-freeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, previous code was hardcoded to true string value without Jinja logic. Oversight when appending additional logic.

@berndfinger berndfinger merged commit 0162963 into sap-linuxlab:dev Dec 18, 2024
3 of 4 checks passed
@berndfinger berndfinger deleted the issue-915-fix-buildJEEusingExtraMileTool branch December 18, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants