Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sap_ha_pacemaker_cluster/SUSE: Rework SAPHanaSR-angi pre-steps and add SLES 16 vars #928

Merged
merged 1 commit into from
Jan 8, 2025
Merged

sap_ha_pacemaker_cluster/SUSE: Rework SAPHanaSR-angi pre-steps and add SLES 16 vars #928

merged 1 commit into from
Jan 8, 2025

Conversation

marcelmamula
Copy link
Contributor

Description

  • pre_steps_hana.yml was updated with new logic to:
    • Angi: Uninstall SAPHanaSR only on SLES 15
    • Classic: Uninstall SAPHanaSR-angi only on SLES 15
  • SLES_16 variables with updated packages

Test results

Successfully tested on SLES4SAP 15 SP6 on AWS with SAP HANA HA scenario:

  • Angi setup was followed by Classic to test if package uninstall works, then Angi again

@marcelmamula marcelmamula added the enhancement New feature or request label Jan 8, 2025
@marcelmamula marcelmamula requested a review from ja9fuchs January 8, 2025 09:35
@marcelmamula marcelmamula self-assigned this Jan 8, 2025
ja9fuchs
ja9fuchs approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@ja9fuchs ja9fuchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine 👍

@marcelmamula marcelmamula merged commit 44e8734 into sap-linuxlab:dev Jan 8, 2025
3 of 4 checks passed
@marcelmamula marcelmamula deleted the angi-detect branch January 8, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ja9fuchs ja9fuchs ja9fuchs approved these changes

Assignees

@marcelmamula marcelmamula

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcelmamula @ja9fuchs