[hint] improve warning for typing source key columns before joining (#…

…2117) * [join-] improve error message for inconsistent key columns Multiple messages are now identical and get batched into a single line. Mention sheets names and column names instead of values. Co-authored-by: Saul Pwanson <[email protected]>
saulpw · Nov 28, 2023 · 4a0ab56 · 4a0ab56
1 parent c1b30c5
commit 4a0ab56
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/visidata/features/join.py b/visidata/features/join.py
@@ -137,7 +137,8 @@ def calcValue(self, row):
             if row[c.sheet] is not None:
                 vals.add(c.getTypedValue(row[c.sheet]))
         if len(vals) != 1:
-            vd.warning(f'inconsistent keys: ' + str(vals))
+            keycolnames = ', '.join([f'{col.sheet.name}:{col.name}' for col in self.keycols])
+            vd.warning(f"source key columns ({keycolnames}) have different types")
         return vals.pop()
 
     def putValue(self, row, value):