Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[aggr-] allow undo for aggregate-col/cols #2602

Merged
merged 1 commit into from
Nov 11, 2024
Merged

[aggr-] allow undo for aggregate-col/cols #2602

merged 1 commit into from
Nov 11, 2024

Conversation

midichef
Copy link
Contributor

After adding an aggregator to a column with +, it can't be removed with undo-last. This PR adds undo.

It also removes an old check for hasattr(col, 'aggregators) that is obsolete, now that Column.aggregators has
become a property.

visidata/visidata/aggregators.py

Line 75 in bee4116

Column.aggregators = property(aggregators_get, aggregators_set)

saulpw
saulpw approved these changes Nov 10, 2024
View reviewed changes
Copy link
Owner

@saulpw saulpw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me! Thanks @midichef.

@anjakefala anjakefala merged commit 59344b6 into saulpw:develop Nov 11, 2024
14 checks passed
@midichef midichef deleted the undo_col_aggr branch November 12, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saulpw saulpw saulpw approved these changes

Assignees
No one assigned
Labels
waiting on maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@midichef @saulpw @anjakefala