Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frame API cleanup, ffmpeg io enhancements. #4318

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

toots
Copy link
Member

@toots toots commented Jan 18, 2025

This PR does some cleanup around the new media/frame API:

  • Frame should really only have one track mark per frame so it's better to had a track mark insertion API that removes all other track marks.
  • Technically, frame can have more than one metadata but it's also better to avoid it so the API is changed accordingly

The ffmpeg IO input is cleaned up accordingly: only one track mark is set per frame and the same for metadata.

Lastly, icy metadata in ffmpeg input can be all over the place so we store them an add them back with each "normal" metadata. With deduplication enabled, this makes the metadata output much more clean.

Enhance ffmpeg IO metadata handling.
@toots toots force-pushed the frame-metadata-breaks-cleanup branch from 70fd994 to 8a1d966 Compare January 18, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant