Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add conda-forge install instructions #41

Merged
merged 1 commit into from
Jan 18, 2025
Merged

docs: Add conda-forge install instructions #41

merged 1 commit into from
Jan 18, 2025

Conversation

matthewfeickert
Copy link
Contributor

@matthewfeickert matthewfeickert commented Dec 20, 2024 •
edited
Loading

Resolves #40

@matthewfeickert
Copy link
Contributor Author

@janfb this is ready for review.

@matthewfeickert
docs: Add conda-forge install instructions
5e9784f 
* Add install instructions from conda-forge for pixi and conda.
   - c.f. https://github.com/conda-forge/pyknos-feedstock
* Add conda-forge badge.
@matthewfeickert matthewfeickert force-pushed the docs/add-conda-forge-install-docs branch from 1ba1db5 to 5e9784f Compare December 20, 2024 21:11
matthewfeickert
matthewfeickert commented Dec 20, 2024
View reviewed changes
README.md
pip install pyknos
To install `pyknos` from PyPI run

```
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

```commandline

is used above, but this has no syntax highlighting effect on GitHub, so just use the default

```

as using

```console

would result in a different color.

@matthewfeickert
Copy link
Contributor Author

matthewfeickert commented Jan 3, 2025 •
edited
Loading

ping @janfb and @michaeldeistler as a reminder given this was opened up over the 2024 holidays.

janfb
janfb approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@janfb janfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ping. Looks good, thanks for adding this! 🙏

@matthewfeickert
Copy link
Contributor Author

👋 @janfb @michaeldeistler as this is approved can this get merged in?

@janfb
Copy link
Contributor

janfb commented Jan 18, 2025

Sorry, I really have to turn on all notifications here..

Thanks for the ping!
👋

@janfb janfb merged commit bd0b843 into sbi-dev:main Jan 18, 2025
4 checks passed
@matthewfeickert
Copy link
Contributor Author

No worries! Also thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janfb janfb janfb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Interest in being added as conda-forge feedstock maintainer?
2 participants
@matthewfeickert @janfb