Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multiprocessing only with num_cores #1117

Merged
merged 4 commits into from
Apr 2, 2024
Merged

multiprocessing only with num_cores #1117

merged 4 commits into from
Apr 2, 2024

Conversation

manuelgloeckler
Copy link
Contributor

@manuelgloeckler manuelgloeckler commented Apr 2, 2024 •
edited by janfb
Loading

Fix for failing tests on workflow

Restrict to number of cores that your machine actually has to fix.

fixes #1111

@manuelgloeckler manuelgloeckler linked an issue Apr 2, 2024 that may be closed by this pull request
test_benchmarking_parallel_simulation fails on CI for one configuration #1111
Closed
@manuelgloeckler
Copy link
Contributor Author

@Baschdl Just implement what was discussed in #1111 i.e. setting workers to 2 and I also relaxed the assert a bit. To get #1063 merged.

Does work for me also with -n auto.

@janfb janfb merged commit c8b87c3 into main Apr 2, 2024
3 checks passed
@janfb janfb deleted the 1111-test_benchmarking_parallel_simulation-fails-on-ci-for-one-configuration branch April 2, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeldeistler michaeldeistler michaeldeistler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test_benchmarking_parallel_simulation fails on CI for one configuration
3 participants
@manuelgloeckler @michaeldeistler @janfb