Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1316: remove sample_dim docstring for condition. #1338

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

janfb
Copy link
Contributor

@janfb janfb commented Dec 19, 2024

In our current shape convention, condition does not have a sample_dim, but the docstring was saying something else.

fixes #1316

@janfb janfb force-pushed the fix-estimator-docstring branch from fc3faa6 to 82185e7 Compare December 19, 2024 14:40
@janfb janfb added this to the Last release 2024 milestone Dec 19, 2024
@janfb janfb linked an issue Dec 19, 2024 that may be closed by this pull request
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.65%. Comparing base (d3f22b5) to head (c56056f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1338       +/-   ##
===========================================
- Coverage   89.40%   78.65%   -10.76%     
===========================================
  Files         118      118               
  Lines        8715     8722        +7     
===========================================
- Hits         7792     6860      -932     
- Misses        923     1862      +939     
Flag Coverage Δ
unittests 78.65% <ø> (-10.76%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sbi/neural_nets/estimators/base.py 64.40% <ø> (ø)
sbi/neural_nets/estimators/nflows_flow.py 63.46% <ø> (ø)
sbi/neural_nets/estimators/zuko_flow.py 64.44% <ø> (ø)

... and 32 files with indirect coverage changes

Copy link
Contributor

@manuelgloeckler manuelgloeckler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good. Just found the small typo (that hower already was there)

@janfb janfb force-pushed the fix-estimator-docstring branch from 82185e7 to c56056f Compare December 20, 2024 13:49
@janfb janfb merged commit 390a518 into main Dec 21, 2024
6 checks passed
@janfb janfb deleted the fix-estimator-docstring branch December 21, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mismatch between doc strings and code in log_prob function
2 participants