Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase tutorial test timeout #1360

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

janfb
Copy link
Contributor

@janfb janfb commented Jan 10, 2025

During the release, the GitHub action that executes and then strips all notebooks before building the docs failed because the decision making example notebook took longer than 10min to execute. Here, we increase to timeout to avoid this failure in the future.

@janfb janfb requested a review from manuelgloeckler January 10, 2025 14:28
Copy link
Contributor

@manuelgloeckler manuelgloeckler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.42%. Comparing base (d3f22b5) to head (0c6e8e2).
Report is 9 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1360       +/-   ##
===========================================
- Coverage   89.40%   78.42%   -10.99%     
===========================================
  Files         118      118               
  Lines        8715     8749       +34     
===========================================
- Hits         7792     6861      -931     
- Misses        923     1888      +965     
Flag Coverage Δ
unittests 78.42% <ø> (-10.99%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 33 files with indirect coverage changes

@janfb janfb merged commit 0bb84d9 into main Jan 10, 2025
6 checks passed
@janfb janfb deleted the increase-tutorial-test-execution-timeout branch January 10, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants