Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dev to main] v1.1.0 #21

Merged
merged 77 commits into from
Apr 25, 2024
Merged

[dev to main] v1.1.0 #21

merged 77 commits into from
Apr 25, 2024

Conversation

lsz05
Copy link
Collaborator

@lsz05 lsz05 commented Apr 24, 2024 •
edited
Loading

ftnext and others added 30 commits March 15, 2024 22:27
@ftnext
refactor: Share fixture with conftest.py
a845eba
@ftnext
refactor: src-layout to install jmteb package
2afd0a0
@ftnext
feat: Support python -m jmteb (alternative of python main.py)
39358b4
@ftnext
style: Fix imports format
d41b888
@ryokan0123
resolve conflicts
9278a8e
@ryokan0123
refactor: aggregate the main function to __main__.py
23c8d09
@ryokan0123
style: fix __main__.py
59fcb65
@masaya-ohagi
Merge pull request #1 from ftnext/main
90968b8 
git cloneだけでなく、リポジトリからpip installしてmain.pyの処理が実行できるようにする
@masaya-ohagi
added reranking evaluator
94fff08
@masaya-ohagi
added rerankingevaluator import
d2ce766
@masaya-ohagi
added esci jsonnet
7b679fb
@masaya-ohagi
increased k of ndcg
9b00f9f
@masaya-ohagi
added test for reranking
6740d9d
@masaya-ohagi
code formatting
bca6114
@masaya-ohagi
isort
ca9c6ae
@masaya-ohagi
added 40 to k of ndcg
5f8a183
@masaya-ohagi
Merge pull request #11 from sbintuitions/add_task/reranking/esci
2ac591f 
Add task/reranking/esci
@lsz05
Add OpenAI embedder
ec640de
@lsz05
Update requirements
5594e7b
@lsz05
Add test cases for OpenAIEmbedder
cc493e3
@lsz05
Use mock OpenAI embedding method in test cases instead of calling API
b71bd36
@lsz05
Remove unnecessary env var
1407213
@lsz05
Fix setting dimension and add related test cases
9e7d49d
@lsz05
Refine test cases
6272c8f
@lsz05
Refine test cases
2d1fd87
@lsz05
Add comment about normalization
1725948
@lsz05
Merge pull request #12 from sbintuitions/feature/openai_api
386a1fa 
[Feature] Add OpenAIEmbedder
@lsz05
Add dev set application for hyperparameter tuning and corresponding t…
39d4420 
…est cases
@lsz05
Add test cases for hyperparameter tuning
b228e06
@lsz05
fix type hints
4f51c3f
lsz05 and others added 25 commits April 17, 2024 20:52
@lsz05 @ryokan0123
Use model constructor
fcd5829 
Co-authored-by: Ryokan RI <[email protected]>
@lsz05 @ryokan0123
Apply model constructor
b9a4548 
Co-authored-by: Ryokan RI <[email protected]>
@lsz05
Use lambda instead of deepcopy
1ecf741
@lsz05
Add type hinting for callable
1a45895
@lsz05
reformat
c440e33
@lsz05
add type hinting
dc9f3ec
@lsz05 @ryokan0123
merge fit and predict in ClusterMixin
49facbc 
Co-authored-by: Ryokan RI <[email protected]>
@lsz05
Fix callable problem
c0e8dfd
@lsz05
Fix type hint
d154122
@lsz05
Merge pull request #13 from sbintuitions/feature/apply_devset
26ef4ec 
[Feature] validation setを用いてhyperparameter tuningをする
@lsz05
Fix AmazonCounterfactualClassification task name
e38b964
@lsz05
Merge pull request #16 from sbintuitions/fix/counterfactual
a92c8f0 
[Fix] AmazonCounterfactualClassificationタスク名タイポ
@lsz05
Truncate input to ensure the max token length is not exceeded
d920f6e
@lsz05
Fix format
60b0fb7
@lsz05
Update requirements
444c45f
@lsz05
Add test cases for max token length and encoder
afd0817
@lsz05
rename function
6214680
@lsz05
Remove text length truncation hacking
d3ecb2a
@lsz05
Merge pull request #17 from sbintuitions/fix/openai_token_length
6e763fb 
[Fix] OpenAIEmbedderにおける長さ超過のインプットテキストの処理
@lsz05
Fix empty string processing in OpenAIEmbedder
56f0bd9
@lsz05
Add OpenAI empty string test case
f0e935b
@lsz05
Add comment for empty string processing
dbf42b9
@lsz05
Merge pull request #19 from sbintuitions/fix/openai_empty_string
65d6dea 
[Fix] OpenAIEmbedderにおけるempty stringの処理
@lsz05
Update version to 1.1.0
6378789
@lsz05
Merge pull request #20 from sbintuitions/v1.1.0
017d2dd 
[Version bump-up] v1.1.0
ryokan0123
ryokan0123 approved these changes Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@ryokan0123 ryokan0123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM です！

@lsz05 lsz05 merged commit 818d4d8 into main Apr 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryokan0123 ryokan0123 ryokan0123 approved these changes

@masaya-ohagi masaya-ohagi Awaiting requested review from masaya-ohagi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lsz05 @ryokan0123 @ftnext @masaya-ohagi