Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [POC] Scale tests & Tracing #153

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

sbueringer
Copy link
Owner

@sbueringer sbueringer commented Jul 7, 2023

Some thoughts on Tracing:

  • Instead of wrapping the reconcilers we should have another util func that we call at the beginning of each top-level Reconcile func (should do the same as traceReconciler.Reconcile at the moment)
  • we should align flags to upstream k/k / component-base
  • we should align the way we create the TracerProvider to k/k / component-base
  • we have to decide for which funcs we open new spans (e.g. only the ones which are expected to take some time (e.g. because of network calls))
  • we should instrument the client-go http client. It's already implemented for the client for the mgmt cluster. There were problems with the workload cluster client (random spans in the trace that took 10s)
  • we should implement a dashboard which makes it easy to analyze trace metrics (first version is included in this PR)

@sbueringer sbueringer force-pushed the pr-scale-experiments branch 2 times, most recently from 172b786 to bf9a7e6 Compare July 7, 2023 09:02
@sbueringer sbueringer force-pushed the pr-scale-experiments branch 3 times, most recently from 5b3ebe5 to 318d69f Compare July 7, 2023 13:04
@sbueringer sbueringer force-pushed the pr-scale-experiments branch from 318d69f to 9fde59c Compare July 10, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant