-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better support for collections outside Scala's std lib #444
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #444 +/- ##
==========================================
+ Coverage 90.06% 90.08% +0.01%
==========================================
Files 125 128 +3
Lines 4763 4761 -2
Branches 430 426 -4
==========================================
- Hits 4290 4289 -1
+ Misses 473 472 -1 ☔ View full report in Codecov by Sentry. |
I have a better idea now:
This collection-awareness would let us define something like |
25da3f9
to
d070c16
Compare
This one will be much easier to implement one #490 lands |
Postponed until #493 lands - then providing integrations would not require providing nested path improvements in the same PR. |
Closed in favor of #505 |
Java collections module introduced on 0.8.0 solved some problems:
java.util.Optional
) similar to support forscala.Option
It has however a few drawbacks:
TransformerOrUpcast
type to avoid issues with automatic vs semiautomatic derivation (prevents having to pick between 2 imports, one for automatically derived internal types and one for only semiautomatically derived)To handle it, the best solution would be to:
This would be a breaking change, so it should not be merged as a part of 0.8.x but it can become a part of future 1.0.0-RC line.
TODO: