bugfix: Remove pausing and window state monitoring #7097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
force-pushed
the
remove-pausing
branch
2 times, most recently
from
37e3d38 to
6a770f6
Compare
kasiaMarek
approved these changes
Jan 9, 2025
tgodzik
force-pushed
the
remove-pausing
branch
from
6a770f6 to
dd850bf
Compare
I finally managed to reproduce an issue where not compilation would be done, turns out the batched functions went into a wrong state and never unpaused. In that case any request would be silently ignored. Since, this looks tricky to make work and the advantage is minimal I think it's best to remove it altogether. It could be useful if we had two heavy compilations one after another, but that very rarely happens, since the next compilation is usually noop.
tgodzik
force-pushed
the
remove-pausing
branch
from
dd850bf to
9f007a9
Compare
|
Great to see one less custom LSP extension! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I finally managed to reproduce an issue where no compilation would be done, turns out that batched functions went into a wrong state and never unpaused. In that case any request would be silently ignored.
Since, this looks tricky to make work and the advantage is minimal I think it's best to remove it altogether. It could be useful if we had two heavy compilations one after another, but that very rarely happens, since the next compilation is usually noop.