Support Scala Native multithreading #861
Conversation
… print stack trace of exceptions and acknoledge optional space before elapsed time on the JVM
| Thread.sleep(ms) | ||
| body | ||
| if (!isMultithreadingEnabled) { | ||
| // Thread.sleep(ms) |
There was a problem hiding this comment.
@WojciechMazur
Why was this added but commented out?
Now it looks like if multithreading is disabled we ignore timeout durations and run body immediately?
There was a problem hiding this comment.
I don't know what's the story of original Thread.sleep call but it makes no sense to have it. The goal of this method was to introduce timeouts, instead it was only slowing the execution, while there was nothing else running in the background.
|
@WojciechMazur do we have an idea of what kind of issues this should fix? And ultimately, should we cut a new release with these changes? |
It would mostly allow to have the same semantics as when execution on the JVM. Can potentially also fix some issues in the async tests due to incorrect behaviour of The new release would be welcome, probably can be made as a patch |
|
Running the release https://github.com/scalameta/munit/releases/tag/v1.0.4 |
Since Scala Native 0.5.0 we have access to multithreading support, it's enabled by default if we detect usage of threading in the compiled code. This change does acknowledge multihreading support in PlatformCompat for Native (mostly copy-paste based on JVM implementation with minor changes)
Additional changes required to unsupress
Issue285FrameworkSuite:<elapsed time>pattern - it is sometimes produced by the JVM