This repository has been archived by the owner on Nov 20, 2024. It is now read-only.
Add CI workflows for testing and building COSI #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcarmet
suggested changes
Sep 12, 2024
anurag4DSB
force-pushed
the
feature/S3C-9222-setup-CI
branch
from
1260298 to
a280c3c
Compare
|
I force pushed but for some reason the CI is not triggering. |
anurag4DSB
force-pushed
the
feature/S3C-9222-setup-CI
branch
from
32fb363 to
1260298
Compare
tcarmet
approved these changes
Sep 13, 2024
tcarmet
reviewed
Sep 13, 2024
Dockerfile
Outdated
| # Copy the source code into the container | ||
| COPY . . | ||
|
|
||
| RUN CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -o scality-cosi-driver ./cmd/scality-cosi-driver |
There was a problem hiding this comment.
Might be better to use an ENV clause for the GO*build vars, then callmake build, and remove the setting of GO*` vars inside Makefile (unless there's a strong reason to build only for linux/amd64, in which case it can stay in the Makefile).
There was a problem hiding this comment.
updated in 0787021
anurag4DSB
commented
Oct 16, 2024
anurag4DSB
commented
Oct 18, 2024
|
Coming in next PRs: Add readme for testing |
jonathan-gramain
approved these changes
Oct 19, 2024
- Update GO version to 1.23.2 - Added Dockerfile, Makefile and CI workflows - Added tests for DriverInfo in identity server using Ginkgo Issue: S3C-9222
anurag4DSB
force-pushed
the
feature/S3C-9222-setup-CI
branch
from
610ef55 to
45bc875
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: development/1 will be remained to
main. We used development/1 originally for this but Platform Engineering let us its not needed.