Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add Freesurfer container #23

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[WIP] Add Freesurfer container #23

wants to merge 5 commits into from

Conversation

arnaudbore
Copy link
Contributor

No description provided.

@arnaudbore arnaudbore requested a review from AlexVCaron April 23, 2024 14:55
AlexVCaron
AlexVCaron requested changes Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@AlexVCaron AlexVCaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty much everything is there ! Once the comments are fixed, it should be good. You don't need scilpy from what I see ?

docker-bake.hcl Outdated Show resolved Hide resolved
containers/freesurfer.context/freesurfer.Dockerfile Show resolved Hide resolved
containers/freesurfer.context/freesurfer.Dockerfile Outdated Show resolved Hide resolved
docker-bake.hcl Outdated Show resolved Hide resolved
docker-bake.hcl Outdated Show resolved Hide resolved
docker-bake.hcl Outdated Show resolved Hide resolved
containers/freesurfer.context/freesurfer.Dockerfile Outdated Show resolved Hide resolved
AlexVCaron
AlexVCaron reviewed Jun 2, 2024
View reviewed changes
containers/freesurfer.context/freesurfer.Dockerfile
FROM freesurfer-base as freesurfer

ARG FREESURFER_VERSION
ENV FREESURFER_VERSION=${FREESURFER_VERSION:-${FREESURFER_VERSION}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this. The latter part sets the default if (1) ARG is not defined or (2) then variable is not defined in env.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexVCaron AlexVCaron AlexVCaron requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arnaudbore @AlexVCaron