-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX]: Return rejected streamlines with empty sft #1076
Conversation
Hello @levje, Thank you for updating ! There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-12-12 15:36:30 UTC |
Is this the same problem or related to issue #1007 ? Can you look into it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
quick comment
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1076 +/- ##
==========================================
+ Coverage 69.45% 69.47% +0.01%
==========================================
Files 447 447
Lines 24025 24050 +25
Branches 3280 3290 +10
==========================================
+ Hits 16687 16709 +22
- Misses 5943 5944 +1
- Partials 1395 1397 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GTG
Quick description
As explained here: #1073
Type of change
Check the relevant options.
Provide data, screenshots, command line to test (if relevant)
pytest scilpy/tractograms/tests/test_streamline_operations.py -k 'test_filter_streamlines_by_length'
Checklist