Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX]: Return rejected streamlines with empty sft #1076

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

levje
Copy link
Contributor

@levje levje commented Dec 12, 2024

Quick description

As explained here: #1073

Type of change

Check the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Provide data, screenshots, command line to test (if relevant)

pytest scilpy/tractograms/tests/test_streamline_operations.py -k 'test_filter_streamlines_by_length'

Checklist

  • My code follows the style guidelines of this project (run autopep8)
  • I added relevant citations to scripts, modules and functions docstrings and descriptions
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I moved all functions from the script file (except the argparser and main) to scilpy modules
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@pep8speaks
Copy link

pep8speaks commented Dec 12, 2024

Hello @levje, Thank you for updating !

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-12-12 15:36:30 UTC

@frheault
Copy link
Member

Is this the same problem or related to issue #1007 ? Can you look into it?

Copy link
Contributor

@arnaudbore arnaudbore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick comment

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.47%. Comparing base (5bcfd7f) to head (1c31cc8).
Report is 43 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1076      +/-   ##
==========================================
+ Coverage   69.45%   69.47%   +0.01%     
==========================================
  Files         447      447              
  Lines       24025    24050      +25     
  Branches     3280     3290      +10     
==========================================
+ Hits        16687    16709      +22     
- Misses       5943     5944       +1     
- Partials     1395     1397       +2     
Components Coverage Δ
Scripts 70.26% <ø> (+<0.01%) ⬆️
Library 68.41% <100.00%> (+0.04%) ⬆️

@levje levje requested a review from arnaudbore December 12, 2024 17:58
Copy link
Contributor

@arnaudbore arnaudbore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG

@arnaudbore arnaudbore added this pull request to the merge queue Dec 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 12, 2024
@arnaudbore arnaudbore added this pull request to the merge queue Dec 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 16, 2024
@arnaudbore arnaudbore added this pull request to the merge queue Dec 16, 2024
Merged via the queue into scilus:master with commit 87b5a30 Dec 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants