Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing bug in gradients_generate_sampling #1094

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

karanphil
Copy link
Contributor

Quick description

There was a small bug with the argument --no_b0_start, it was missing action='store_true and was just doing nothing.

...

Type of change

Check the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Provide data, screenshots, command line to test (if relevant)

...

Checklist

  • My code follows the style guidelines of this project (run autopep8)
  • I added relevant citations to scripts, modules and functions docstrings and descriptions
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I moved all functions from the script file (except the argparser and main) to scilpy modules
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@karanphil karanphil requested a review from arnaudbore December 12, 2024 18:41
Copy link
Contributor

@arnaudbore arnaudbore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@arnaudbore arnaudbore enabled auto-merge December 12, 2024 18:46
@arnaudbore arnaudbore added this pull request to the merge queue Dec 12, 2024
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.46%. Comparing base (e256482) to head (da8863b).
Report is 59 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1094   +/-   ##
=======================================
  Coverage   69.46%   69.46%           
=======================================
  Files         447      447           
  Lines       24052    24052           
  Branches     3291     3291           
=======================================
  Hits        16708    16708           
  Misses       5946     5946           
  Partials     1398     1398           
Components Coverage Δ
Scripts 70.26% <100.00%> (ø)
Library 68.39% <ø> (ø)

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 12, 2024
@arnaudbore arnaudbore added this pull request to the merge queue Dec 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 16, 2024
@arnaudbore arnaudbore added this pull request to the merge queue Dec 17, 2024
Merged via the queue into scilus:master with commit 39e9b5e Dec 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants