Update script scil_viz_gradients_screenshot #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1097 +/- ##
==========================================
+ Coverage 69.46% 69.54% +0.07%
==========================================
Files 447 448 +1
Lines 24052 24076 +24
Branches 3291 3290 -1
==========================================
+ Hits 16708 16743 +35
+ Misses 5946 5940 -6
+ Partials 1398 1393 -5
|
karanphil
changed the title
karanphil
changed the title
arnaudbore
previously approved these changes
Dec 17, 2024
Done! |
EmmaRenauld
approved these changes
Dec 18, 2024
| @@ -88,7 +89,7 @@ def main(): | |||
|
|
|||
| if len(args.in_gradient_scheme) == 2: | |||
| assert_gradients_filenames_valid(parser, args.in_gradient_scheme, | |||
| 'fsl') | |||
| True) | |||
There was a problem hiding this comment.
Can you please put input_is_fsl=True, instead of only True?
| @@ -97,7 +98,7 @@ def main(): | |||
| else: | |||
| assert_gradients_filenames_valid(parser, | |||
| args.in_gradient_scheme, | |||
| 'mrtrix') | |||
| False) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick description
The reading of .bvals and .bvecs files was outdated in
scil_viz_gradients_screenshot.py. I used read_bvals_bvecs instead. Also, I changed the last argument given toassert_gradients_filenames_valid, which was not working at all. (supposed to be a bool but was 'fsl' or 'mrtrix')...
Type of change
Check the relevant options.
Provide data, screenshots, command line to test (if relevant)
...
Checklist