-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC - renamed the uncompress fct to streamlines_to_voxel_coordinates #1103
base: master
Are you sure you want to change the base?
Conversation
6e031ee
to
8568800
Compare
Hello @gabknight, Thank you for updating ! There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2025-01-09 20:38:12 UTC |
8568800
to
4ff7eff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (when tests pass)
scilpy/tractograms/uncompress.pyx
Outdated
@@ -12,7 +12,7 @@ cimport numpy as cnp | |||
|
|||
cdef struct Pointers: | |||
# Incremented when we complete a streamline. Saved at the start of each | |||
# streamline because we need to start anew if we resize data_out | |||
# streamline because we need to start a new if we resize data_out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that anew was ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, fixed :)
4ff7eff
to
e934874
Compare
e934874
to
ec6db41
Compare
Quick description
For clarity, the
uncompress(.)
function was renamedstreamlines_to_voxel_coordinates
.The module remains named
scilpy.tractogram.uncompress
....
Type of change
Check the relevant options.
Provide data, screenshots, command line to test (if relevant)
...
Checklist