Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Migrate code from CHrlS98/aodf_toolkit #722

Closed
wants to merge 1 commit into from

Conversation

CHrlS98
Copy link
Contributor

@CHrlS98 CHrlS98 commented May 23, 2023

Quick description

Migrate code from https://github.com/CHrlS98/aodf-toolkit back into scilpy.

Code from my MSc project.

To run,

scil_compute_asymmetric_odf.py --disable_angle input.nii.gz output.nii.gz
  • disable_angle speeds up the computation and is good enough.

@arnaudbore

Type of change

Check the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Provide data, screenshots, command line to test (if relevant)

...

Checklist

  • My code follows the style guidelines of this project (run autopep8)
  • I added relevant citations to scripts, modules and functions docstrings and descriptions
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I moved all functions from the script file (except the argparser and main) to scilpy modules
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@arnaudbore arnaudbore self-requested a review May 23, 2023 20:25
@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

1 similar comment
@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

@arnaudbore arnaudbore added the WIP Work In Progress label Nov 2, 2023
@CHrlS98 CHrlS98 mentioned this pull request Feb 27, 2024
13 tasks
@CHrlS98
Copy link
Contributor Author

CHrlS98 commented Feb 27, 2024

See #925. I'm closing this one.

@CHrlS98 CHrlS98 closed this Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work In Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants