Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation #889

Merged
merged 5 commits into from
Feb 23, 2024
Merged

Fix documentation #889

merged 5 commits into from
Feb 23, 2024

Conversation

arnaudbore
Copy link
Contributor

@arnaudbore arnaudbore commented Jan 30, 2024

Quick description

The scilpy web site has not changed since 2020 - This is an attempt to fix it and make it work
...

Type of change

Check the relevant options.

  • Bug fix (non-breaking change which fixes an issue)

...

Checklist

  • My code follows the style guidelines of this project (run autopep8)
  • I added relevant citations to scripts, modules and functions docstrings and descriptions
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I moved all functions from the script file (except the argparser and main) to scilpy modules
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@arnaudbore arnaudbore requested a review from frheault January 31, 2024 00:28
@arnaudbore
Copy link
Contributor Author

Build passed ! Good Job 🍻 !

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.84%. Comparing base (c70787f) to head (f0db0e0).
Report is 12 commits behind head on master.

❗ Current head f0db0e0 differs from pull request most recent head de5cca9. Consider uploading reports for the commit de5cca9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #889      +/-   ##
==========================================
- Coverage   68.85%   68.84%   -0.01%     
==========================================
  Files         388      388              
  Lines       20951    20951              
  Branches     3217     3217              
==========================================
- Hits        14425    14423       -2     
- Misses       5205     5206       +1     
- Partials     1321     1322       +1     
Components Coverage Δ
Scripts 71.26% <100.00%> (-0.02%) ⬇️
Library 64.65% <ø> (ø)

@pep8speaks
Copy link

pep8speaks commented Feb 23, 2024

Hello @arnaudbore, Thank you for updating !

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-02-23 21:28:16 UTC

@arnaudbore arnaudbore changed the title [WIP] Fix documentation Fix documentation Feb 23, 2024
@arnaudbore arnaudbore merged commit 82fdf5f into scilus:master Feb 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants