Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick description
I tried to uniformize the verbose option across scripts. This was a nightmare. It is a really big WIP. I will need input from power users of each scripts. For example:
I am uncertain of all bundle/connectivity scripts. Everything that loads or saves tractograms has logging.info somewhere (formely logging.debug), so I added a verbose option for INFO. But there might be some debug in Dipy... The tractogram scripts probably all have the same issue, so I did touch them for the moment.
Also, I changed the level from DEBUG to INFO in
scil_freewater_maps.py
andscil_NODDI_maps.py,
but I am not sure of the logging level in COMMIT.Some cases are hard to choose between DEBUG and INFO... like
scil_gradients_generate_sampling.py
. There is a reason for both INFO and DEBUG to be present, but now that WARNING is the default, we only have the option to see none of the messages, or all of it (both INFO and DEBUG), or never see the DEBUG stuff.scil_NODDI_priors.py
also have this problem... both debug and info, so with WARNING as default we don't have a choice between INFO and DEBUG with verbose. Same forscil_search_keywords.py
.I am not sure I understand why the verbose argument is setup the way it is in
scil_tracking_pft.py
.I did not touch the visualization scripts.
...
Type of change
Check the relevant options.
Provide data, screenshots, command line to test (if relevant)
...
Checklist