Add gradient_utils unit tests #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @EmmaRenauld, Thank you for updating ! There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-02-20 13:39:03 UTC |
EmmaRenauld
force-pushed
the
test_gradients_utils
branch
from
39a2d4e to
34f04c6
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #903 +/- ##
==========================================
+ Coverage 65.95% 65.97% +0.01%
==========================================
Files 384 386 +2
Lines 21352 21573 +221
Branches 3495 3540 +45
==========================================
+ Hits 14083 14233 +150
- Misses 5661 5706 +45
- Partials 1608 1634 +26
|
karanphil
reviewed
Feb 16, 2024
scilpy/gradients/utils.py
Outdated
| @@ -3,10 +3,14 @@ | |||
| import numpy as np | |||
|
|
|||
|
|
|||
| def random_uniform_on_sphere(nb_vectors): | |||
| def random_uniform_on_half_sphere(nb_vectors): | |||
There was a problem hiding this comment.
I don't think this produces points on the half sphere, but rather the whole sphere. I believe the previous name was right.
There was a problem hiding this comment.
Ok, I'll change back!
Here is the plot from running it a few times with 10 points.
There was a problem hiding this comment.
Not super well distributed, but not a half sphere
karanphil
approved these changes
Feb 19, 2024
scilpy/gradients/utils.py
Outdated
| Philips gradient table | ||
| dwis: nibabel | ||
| dwis | ||
| ref_gradients_table: nd.array |
There was a problem hiding this comment.
ref_gradient_table, no s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick description
Unit tests for the file gradients_utils.
As discussed, not sure about the random sphere thing... Went back to Caruyer's code, and it says on the half-sphere! Anyone understand why?
Type of change
Check the relevant options.
Provide data, screenshots, command line to test (if relevant)
...
Checklist