Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add possibility to use a label mask with two values to cut streamlines #945

Merged
merged 12 commits into from
Apr 10, 2024

Conversation

arnaudbore
Copy link
Contributor

@arnaudbore arnaudbore commented Mar 13, 2024

Quick description

New way of cutting streamlines. Use a label image and select your IDs to cut streamlines
...

Type of change

Check the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Provide data, screenshots, command line to test (if relevant)

...

Checklist

  • My code follows the style guidelines of this project (run autopep8)
  • I added relevant citations to scripts, modules and functions docstrings and descriptions
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I moved all functions from the script file (except the argparser and main) to scilpy modules
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@arnaudbore arnaudbore added the WIP Work In Progress label Mar 13, 2024
@arnaudbore arnaudbore requested a review from frheault March 14, 2024 01:15
@arnaudbore arnaudbore closed this Mar 25, 2024
@arnaudbore arnaudbore deleted the extend_cut_streamlines branch March 25, 2024 20:32
@arnaudbore arnaudbore restored the extend_cut_streamlines branch March 25, 2024 20:32
@arnaudbore arnaudbore reopened this Mar 26, 2024
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 44.68085% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 67.99%. Comparing base (173f70b) to head (9c0c7b3).
Report is 42 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #945      +/-   ##
==========================================
+ Coverage   66.98%   67.99%   +1.00%     
==========================================
  Files         396      397       +1     
  Lines       21396    21396              
  Branches     3251     3239      -12     
==========================================
+ Hits        14333    14549     +216     
+ Misses       5749     5532     -217     
- Partials     1314     1315       +1     
Components Coverage Δ
Scripts 68.98% <45.23%> (+0.92%) ⬆️
Library 66.48% <40.00%> (+1.16%) ⬆️

@pep8speaks
Copy link

pep8speaks commented Mar 27, 2024

Hello @arnaudbore, Thank you for updating !

Line 164:80: E501 line too long (84 > 79 characters)

Comment last updated at 2024-04-10 18:58:04 UTC

@frheault
Copy link
Member

frheault commented Apr 9, 2024

It works well!

Could you add the parameters to use in the error message (--label_ids)
parser.error('More than two values in the label file.')

@arnaudbore arnaudbore merged commit 48911be into scilus:master Apr 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work In Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants