Volumes scripts

[EmmaRenauld]

Quick description

Cleaning the scripts in the volume column.

Type of change

Check the relevant options.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Provide data, screenshots, command line to test (if relevant)

...

Checklist

• My code follows the style guidelines of this project (run autopep8)
• I added relevant citations to scripts, modules and functions docstrings and descriptions
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I moved all functions from the script file (except the argparser and main) to scilpy modules
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[pep8speaks]

Hello @EmmaRenauld, Thank you for updating !

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-04-03 12:52:56 UTC

[EmmaRenauld]

@frheault Could you please help us have a better doc of the scil_volume_b0_synthesis? Why does it take as input a b0 to create a b0? Thanks!!

[codecov]

Codecov Report

Attention: Patch coverage is 58.95522% with 55 lines in your changes are missing coverage. Please review.

Project coverage is 67.65%. Comparing base (377bed3) to head (ef3859a).

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #947      +/-   ##
==========================================
+ Coverage   66.98%   67.65%   +0.66%     
==========================================
  Files         396      397       +1     
  Lines       21411    21418       +7     
  Branches     3253     3249       -4     
==========================================
+ Hits        14343    14490     +147     
+ Misses       5752     5605     -147     
- Partials     1316     1323       +7     

Components	Coverage Δ
Scripts	68.68% <53.62%> (+0.61%)	⬆️
Library	66.07% <64.61%> (+0.76%)	⬆️

[arnaudbore]

GTG but one quick comment

[arnaudbore]

I liked François' way better... what made you change it ?

[EmmaRenauld]

It didn't work. If you didn't have tensorflow, the whole file was skipped, even the help test above, not this method only. You can see in the code coverage that the script had 0% coverage, so not even the help: https://app.codecov.io/gh/scilus/scilpy/blob/master/scripts%2Fscil_volume_b0_synthesis.py

We checked with Alex, this is the solution we found.

[karanphil]

Looks good to me. Just two minor comments before merging.