MAINT: Move sanitizers specific blocks behind a flag #3611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (8)
- lib/CMakeLists.txt: Language not supported
- lib/cmake/scipp-install.cmake: Language not supported
- lib/common/test/CMakeLists.txt: Language not supported
- lib/core/test/CMakeLists.txt: Language not supported
- lib/dataset/test/CMakeLists.txt: Language not supported
- lib/python/CMakeLists.txt: Language not supported
- lib/units/test/CMakeLists.txt: Language not supported
- lib/variable/test/CMakeLists.txt: Language not supported
SimonHeybrock
approved these changes
Nov 21, 2024
SimonHeybrock
approved these changes
Nov 21, 2024
|
Seems like the windows build issue is coming from upstream actions/runner-images#11016 |
MridulS
force-pushed
the
sanitizers_comment_out
branch
from
0d716c5 to
3fc37aa
Compare
MridulS
force-pushed
the
sanitizers_comment_out
branch
from
5686aa9 to
1cb6cb2
Compare
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (10)
- CMakePresets.json: Language not supported
- lib/CMakeLists.txt: Language not supported
- lib/cmake/scipp-install.cmake: Language not supported
- lib/common/test/CMakeLists.txt: Language not supported
- lib/core/test/CMakeLists.txt: Language not supported
- lib/dataset/test/CMakeLists.txt: Language not supported
- lib/dataset/test/bin_test.cpp: Language not supported
- lib/python/CMakeLists.txt: Language not supported
- lib/units/test/CMakeLists.txt: Language not supported
- lib/variable/test/CMakeLists.txt: Language not supported
SimonHeybrock
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us build (and package) scipp without including the cmake-sanitizers submodule. Conda-forge doesn't really like building with submodules.