Detect Bitnami image in Docker Compose factories

scottfrederick · Nov 17, 2023 · 609218e · 609218e
1 parent caeffc4
commit 609218e
Show file tree

Hide file tree

Showing 20 changed files with 16 additions and 27 deletions.
diff --git a/...amework/boot/docker/compose/service/connection/DockerComposeConnectionDetailsFactory.java b/...amework/boot/docker/compose/service/connection/DockerComposeConnectionDetailsFactory.java
@@ -79,6 +79,10 @@ private boolean hasRequiredClasses() {
 			.allMatch((requiredClassName) -> ClassUtils.isPresent(requiredClassName, null));
 	}
 
+	protected static Predicate<DockerComposeConnectionSource> connectionName(String connectionName) {
+		return new ConnectionNamePredicate(connectionName);
+	}
+
 	/**
 	 * Get the {@link ConnectionDetails} from the given {@link RunningService}
 	 * {@code source}. May return {@code null} if no connection can be created. Result

diff --git a/.../compose/service/connection/cassandra/CassandraDockerComposeConnectionDetailsFactory.java b/.../compose/service/connection/cassandra/CassandraDockerComposeConnectionDetailsFactory.java
@@ -35,7 +35,7 @@ class CassandraDockerComposeConnectionDetailsFactory
 	private static final int CASSANDRA_PORT = 9042;
 
 	CassandraDockerComposeConnectionDetailsFactory() {
-		super("cassandra");
+		super(connectionName("cassandra").or(connectionName("bitnami/cassandra")));
 	}
 
 	@Override

diff --git a/.../service/connection/elasticsearch/ElasticsearchDockerComposeConnectionDetailsFactory.java b/.../service/connection/elasticsearch/ElasticsearchDockerComposeConnectionDetailsFactory.java
@@ -38,7 +38,7 @@ class ElasticsearchDockerComposeConnectionDetailsFactory
 	private static final int ELASTICSEARCH_PORT = 9200;
 
 	protected ElasticsearchDockerComposeConnectionDetailsFactory() {
-		super("elasticsearch");
+		super(connectionName("elasticsearch").or(connectionName("bitnami/elasticsearch")));
 	}
 
 	@Override

diff --git a/.../compose/service/connection/mariadb/MariaDbJdbcDockerComposeConnectionDetailsFactory.java b/.../compose/service/connection/mariadb/MariaDbJdbcDockerComposeConnectionDetailsFactory.java
@@ -34,7 +34,7 @@ class MariaDbJdbcDockerComposeConnectionDetailsFactory
 		extends DockerComposeConnectionDetailsFactory<JdbcConnectionDetails> {
 
 	protected MariaDbJdbcDockerComposeConnectionDetailsFactory() {
-		super("mariadb");
+		super(connectionName("mariadb").or(connectionName("bitnami/mariadb")));
 	}
 
 	@Override

diff --git a/...compose/service/connection/mariadb/MariaDbR2dbcDockerComposeConnectionDetailsFactory.java b/...compose/service/connection/mariadb/MariaDbR2dbcDockerComposeConnectionDetailsFactory.java
@@ -36,7 +36,7 @@ class MariaDbR2dbcDockerComposeConnectionDetailsFactory
 		extends DockerComposeConnectionDetailsFactory<R2dbcConnectionDetails> {
 
 	MariaDbR2dbcDockerComposeConnectionDetailsFactory() {
-		super("mariadb", "io.r2dbc.spi.ConnectionFactoryOptions");
+		super(connectionName("mariadb").or(connectionName("bitnami/mariadb")), "io.r2dbc.spi.ConnectionFactoryOptions");
 	}
 
 	@Override

diff --git a/...t/docker/compose/service/connection/mongo/MongoDockerComposeConnectionDetailsFactory.java b/...t/docker/compose/service/connection/mongo/MongoDockerComposeConnectionDetailsFactory.java
@@ -37,7 +37,7 @@ class MongoDockerComposeConnectionDetailsFactory extends DockerComposeConnection
 	private static final int MONGODB_PORT = 27017;
 
 	protected MongoDockerComposeConnectionDetailsFactory() {
-		super("mongo", "com.mongodb.ConnectionString");
+		super(connectionName("mongo").or(connectionName("bitnami/mongodb")), "com.mongodb.ConnectionString");
 	}
 
 	@Override

diff --git a/...cker/compose/service/connection/mysql/MySqlJdbcDockerComposeConnectionDetailsFactory.java b/...cker/compose/service/connection/mysql/MySqlJdbcDockerComposeConnectionDetailsFactory.java
@@ -34,7 +34,7 @@ class MySqlJdbcDockerComposeConnectionDetailsFactory
 		extends DockerComposeConnectionDetailsFactory<JdbcConnectionDetails> {
 
 	protected MySqlJdbcDockerComposeConnectionDetailsFactory() {
-		super("mysql");
+		super(connectionName("mysql").or(connectionName("bitnami/mysql")));
 	}
 
 	@Override

diff --git a/...ker/compose/service/connection/mysql/MySqlR2dbcDockerComposeConnectionDetailsFactory.java b/...ker/compose/service/connection/mysql/MySqlR2dbcDockerComposeConnectionDetailsFactory.java
@@ -36,7 +36,7 @@ class MySqlR2dbcDockerComposeConnectionDetailsFactory
 		extends DockerComposeConnectionDetailsFactory<R2dbcConnectionDetails> {
 
 	MySqlR2dbcDockerComposeConnectionDetailsFactory() {
-		super("mysql", "io.r2dbc.spi.ConnectionFactoryOptions");
+		super(connectionName("mysql").or(connectionName("bitnami/mysql")), "io.r2dbc.spi.ConnectionFactoryOptions");
 	}
 
 	@Override

diff --git a/...ompose/service/connection/postgres/PostgresJdbcDockerComposeConnectionDetailsFactory.java b/...ompose/service/connection/postgres/PostgresJdbcDockerComposeConnectionDetailsFactory.java
@@ -34,7 +34,7 @@ class PostgresJdbcDockerComposeConnectionDetailsFactory
 		extends DockerComposeConnectionDetailsFactory<JdbcConnectionDetails> {
 
 	protected PostgresJdbcDockerComposeConnectionDetailsFactory() {
-		super("postgres");
+		super(connectionName("postgres").or(connectionName("bitnami/postgresql")));
 	}
 
 	@Override

diff --git a/...mpose/service/connection/postgres/PostgresR2dbcDockerComposeConnectionDetailsFactory.java b/...mpose/service/connection/postgres/PostgresR2dbcDockerComposeConnectionDetailsFactory.java
@@ -36,7 +36,8 @@ class PostgresR2dbcDockerComposeConnectionDetailsFactory
 		extends DockerComposeConnectionDetailsFactory<R2dbcConnectionDetails> {
 
 	PostgresR2dbcDockerComposeConnectionDetailsFactory() {
-		super("postgres", "io.r2dbc.spi.ConnectionFactoryOptions");
+		super(connectionName("postgres").or(connectionName("bitnami/postgresql")),
+				"io.r2dbc.spi.ConnectionFactoryOptions");
 	}
 
 	@Override

diff --git a/...docker/compose/service/connection/rabbit/RabbitDockerComposeConnectionDetailsFactory.java b/...docker/compose/service/connection/rabbit/RabbitDockerComposeConnectionDetailsFactory.java
@@ -37,7 +37,7 @@ class RabbitDockerComposeConnectionDetailsFactory
 	private static final int RABBITMQ_PORT = 5672;
 
 	protected RabbitDockerComposeConnectionDetailsFactory() {
-		super("rabbitmq");
+		super(connectionName("rabbitmq").or(connectionName("bitnami/rabbitmq")));
 	}
 
 	@Override

diff --git a/...t/docker/compose/service/connection/redis/RedisDockerComposeConnectionDetailsFactory.java b/...t/docker/compose/service/connection/redis/RedisDockerComposeConnectionDetailsFactory.java
@@ -34,7 +34,7 @@ class RedisDockerComposeConnectionDetailsFactory extends DockerComposeConnection
 	private static final int REDIS_PORT = 6379;
 
 	RedisDockerComposeConnectionDetailsFactory() {
-		super("redis");
+		super(connectionName("redis").or(connectionName("bitnami/redis")));
 	}
 
 	@Override

diff --git a/...framework/boot/docker/compose/service/connection/cassandra/cassandra-bitnami-compose.yaml b/...framework/boot/docker/compose/service/connection/cassandra/cassandra-bitnami-compose.yaml
@@ -6,5 +6,3 @@ services:
     environment:
       - 'CASSANDRA_ENDPOINT_SNITCH=GossipingPropertyFileSnitch'
       - 'CASSANDRA_DC=dc1'
-    labels:
-      org.springframework.boot.service-connection: cassandra
diff --git a/...k/boot/docker/compose/service/connection/elasticsearch/elasticsearch-bitnami-compose.yaml b/...k/boot/docker/compose/service/connection/elasticsearch/elasticsearch-bitnami-compose.yaml
@@ -7,5 +7,3 @@ services:
     ports:
       - '9200'
       - '9300'
-    labels:
-      org.springframework.boot.service-connection: elasticsearch
diff --git a/...ringframework/boot/docker/compose/service/connection/mariadb/mariadb-bitnami-compose.yaml b/...ringframework/boot/docker/compose/service/connection/mariadb/mariadb-bitnami-compose.yaml
@@ -8,5 +8,3 @@ services:
       - 'MARIADB_USER=myuser'
       - 'MARIADB_PASSWORD=secret'
       - 'MARIADB_DATABASE=mydatabase'
-    labels:
-      org.springframework.boot.service-connection: mariadb
diff --git a/...g/springframework/boot/docker/compose/service/connection/mongo/mongo-bitnami-compose.yaml b/...g/springframework/boot/docker/compose/service/connection/mongo/mongo-bitnami-compose.yaml
@@ -7,5 +7,3 @@ services:
       - 'MONGO_INITDB_ROOT_USERNAME=root'
       - 'MONGO_INITDB_ROOT_PASSWORD=secret'
       - 'MONGO_INITDB_DATABASE=mydatabase'
-    labels:
-      org.springframework.boot.service-connection: mongo
diff --git a/...g/springframework/boot/docker/compose/service/connection/mysql/mysql-bitnami-compose.yaml b/...g/springframework/boot/docker/compose/service/connection/mysql/mysql-bitnami-compose.yaml
@@ -8,5 +8,3 @@ services:
       - 'MYSQL_USER=myuser'
       - 'MYSQL_PASSWORD=secret'
       - 'MYSQL_DATABASE=mydatabase'
-    labels:
-      org.springframework.boot.service-connection: mysql
diff --git a/...ngframework/boot/docker/compose/service/connection/postgres/postgres-bitnami-compose.yaml b/...ngframework/boot/docker/compose/service/connection/postgres/postgres-bitnami-compose.yaml
@@ -7,5 +7,3 @@ services:
       - 'POSTGRES_USER=myuser'
       - 'POSTGRES_DB=mydatabase'
       - 'POSTGRES_PASSWORD=secret'
-    labels:
-      org.springframework.boot.service-connection: postgres
diff --git a/...springframework/boot/docker/compose/service/connection/rabbit/rabbit-bitnami-compose.yaml b/...springframework/boot/docker/compose/service/connection/rabbit/rabbit-bitnami-compose.yaml
@@ -6,5 +6,3 @@ services:
       - 'RABBITMQ_DEFAULT_PASS=secret'
     ports:
       - '5672'
-    labels:
-      org.springframework.boot.service-connection: rabbitmq
diff --git a/...g/springframework/boot/docker/compose/service/connection/redis/redis-bitnami-compose.yaml b/...g/springframework/boot/docker/compose/service/connection/redis/redis-bitnami-compose.yaml
@@ -5,5 +5,3 @@ services:
       - '6379'
     environment:
       - 'ALLOW_EMPTY_PASSWORD=yes'
-    labels:
-      org.springframework.boot.service-connection: redis
-Original file line number
+Diff line change
@@ Expand Up / @@ -7,5 +7,3 @@ services: @@
         ports:
           - '9200'
           - '9300'
-        labels:
-          org.springframework.boot.service-connection: elasticsearch