Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement sampling #807

Merged
merged 27 commits into from
Jan 15, 2025
Merged

Implement sampling #807

merged 27 commits into from
Jan 15, 2025

Conversation

quinnmil
Copy link
Contributor

@quinnmil quinnmil commented Jan 7, 2025 •
edited
Loading

Changes

  • Instantiates the new Sampler class as a singleton class variable of the tracked_request class.
  • Uses the Sampler.should _sample->bool inside the finish method of the same class.
  • adds test to check singleton functionality.

@quinnmil quinnmil force-pushed the 806-implement-sampling branch 2 times, most recently from 36dff70 to 7395b58 Compare January 7, 2025 21:43
@quinnmil quinnmil force-pushed the 804-add-sampling-logic branch from 08eb143 to f9d92f2 Compare January 7, 2025 21:43
@quinnmil quinnmil force-pushed the 806-implement-sampling branch from 7395b58 to da3bfab Compare January 7, 2025 21:44
@quinnmil quinnmil marked this pull request as ready for review January 7, 2025 23:10
@quinnmil quinnmil force-pushed the 806-implement-sampling branch 2 times, most recently from 7dd9fd3 to ceab2c1 Compare January 10, 2025 16:33
mitchh456
mitchh456 reviewed Jan 13, 2025
View reviewed changes
@quinnmil quinnmil force-pushed the 806-implement-sampling branch 2 times, most recently from 3019116 to 4b4d71e Compare January 14, 2025 20:02
Base automatically changed from 804-add-sampling-logic to master January 15, 2025 01:43
@quinnmil quinnmil force-pushed the 806-implement-sampling branch from bcc18f1 to fca26d2 Compare January 15, 2025 01:47
quinnmil and others added 18 commits January 14, 2025 17:54
@quinnmil
add new sampling configuration keys and converters
942c0c6
@quinnmil
add types to all config methods
fe829b1
@pre-commit-ci @quinnmil
[pre-commit.ci] auto fixes from pre-commit.com hooks
60e9e25 
for more information, see https://pre-commit.ci
@quinnmil
use 0-100 ints instead of floats
b248ba5
@quinnmil
add sampler module
16eaff7
@quinnmil
add sampler tests
7229c75
@quinnmil
improve sampler tests
e501b7b
@quinnmil
fix always sample endpoint test
0574fd9
@quinnmil
remove unnecessary logging
1915274
@quinnmil
remove debug logging
41867ef
@quinnmil
short circuit sampling logic if no sampling configured
bb39635
@quinnmil
simplify pattern match
d9cf86c 
add support for sample_endpoint/job_rate
@quinnmil
rename config option to X_sample_rate
5998f80
@quinnmil
check endpoint/job sample rate in any_sampling
bf3e393
@quinnmil
add test assertion
0090e94
@quinnmil
add test assertion
82b626a
@quinnmil
refactor sampler to better handler legacy ignore and prioritization
b552529
@quinnmil
de-couple from TrackedRequest
a235170
@quinnmil quinnmil force-pushed the 806-implement-sampling branch from fca26d2 to c81950a Compare January 15, 2025 02:09
@quinnmil quinnmil merged commit 226d564 into master Jan 15, 2025
14 checks passed
@quinnmil quinnmil deleted the 806-implement-sampling branch January 15, 2025 20:51
@quinnmil quinnmil linked an issue Jan 15, 2025 that may be closed by this pull request
Implement sampling #806
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchh456 mitchh456 mitchh456 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement sampling
2 participants
@quinnmil @mitchh456