feat(3143): Add regex for stage setup or teardown job names #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VonnyJap
previously approved these changes
Aug 8, 2024
sagar1312
requested changes
Aug 8, 2024
config/regex.js
Outdated
| STAGE_SETUP_PATTERN: /^stage@([\w-]+):setup$/ | ||
| STAGE_SETUP_PATTERN: /^stage@([\w-]+):setup$/, | ||
| // Stage setup pattern. Can be stage@stage-name:setup or stage@stage-name:teardown | ||
| STAGE_SETUP_TEARDOWN_PATTERN: /^stage@([\w-]+):(setup|teardown)$/ |
There was a problem hiding this comment.
Lets move this where the regex related to job names are declared.
May be after PR_JOB_NAME
Suggested change
| STAGE_SETUP_TEARDOWN_PATTERN: /^stage@([\w-]+):(setup|teardown)$/ | |
| STAGE_SETUP_TEARDOWN_JOB_NAME: /^stage@([\w-]+):(setup|teardown)$/ |
test/config/regex.test.js
Outdated
| }); | ||
|
|
||
| it('does not match invalid stage setup or teardown jobs', () => { | ||
| ['stage@alpha', 'alpha-deploy', 'alpha:setup', 'stage@setup'].forEach(trigger => { |
There was a problem hiding this comment.
Add more samples stage@alpha:deploy, stage@teardown, sd@1234:stage@alpha:setup, sd@1234:stage@alpha:teardown
sagar1312
reviewed
Aug 8, 2024
config/regex.js
Outdated
| @@ -45,6 +45,8 @@ module.exports = { | |||
| JOB_NAME: /^(([\w-]+)|(?:stage@([\w-]+):(setup|teardown)))$/, | |||
| // PR JOB Name can only be PR-1 or PR-1:main, group1: PR-prNum, group2: jobName | |||
| PR_JOB_NAME: /^(PR-\d+)(?::([\w-]+))?$/, | |||
| // Stage setup pattern. Can be stage@stage-name:setup or stage@stage-name:teardown | |||
There was a problem hiding this comment.
Suggested change
| // Stage setup pattern. Can be stage@stage-name:setup or stage@stage-name:teardown | |
| // Stage setup or teardown job name. Can be stage@stage-name:setup or stage@stage-name:teardown |
sagar1312
changed the title
sagar1312
approved these changes
Aug 8, 2024
sagar1312
deleted the
hiftikhar01_feat_3413_define_regex_for_stage_setup_or_teardown_jobs
branch
|
🎉 This PR is included in version 23.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
No regex exists to check if a job is one of stage setup or teardown
Objective
Add regex to check if a job is a stage setup or teardown
References
screwdriver-cd/screwdriver#3143
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.