Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(3146): Get repository data from scmRepo without GitHub access [3] #624

Merged

Conversation

y-oksaku
Copy link
Contributor

Context

We will be able to get repository data from pipeline.scmRepo by the following PR.
screwdriver-cd/scm-github#231

Objective

Pass scmRepo to skip GitHub access and get repository data from it.

References

Prior PRs

Issue

License

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

y-oksaku added 2 commits July 17, 2024 03:20
@y-oksaku
Copy link
Contributor Author

If we pass scmRepo here, then it does not fetch latest data from GitHub. It uses own scmRepo data forever and it will not be updated.
So we must not pass scmRepo here.

models/lib/pipeline.js

Lines 1748 to 1753 in 8291226

return this.scm
.decorateUrl({
scmUri: this.scmUri,
scmContext: this.scmContext,
token
})

y-oksaku added 2 commits July 17, 2024 03:42
Copy link
Member

@tkyi tkyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@y-oksaku
Copy link
Contributor Author

Should we pass in scmRepo for these other methods in lib/pipeline.js?

I agree that, so I added scmRepo for other methods.
(This was due to a modification only the execution of the build 🙏 )

@tkyi tkyi merged commit 0e27a66 into screwdriver-cd:master Jul 18, 2024
2 checks passed
@sd-buildbot
Copy link

🎉 This PR is included in version 29.21.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@y-oksaku y-oksaku deleted the feat-pass-scmRepo-arg branch July 19, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants