feat(3143): When a event is started from a job in the middle of a stage, execute setup hook before executing that job. #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tFrom to the setup of the same stage
ThehamzaIftikhar
changed the title
sagar1312
changed the title
sagar1312
reviewed
Aug 9, 2024
test/lib/eventFactory.test.js
Outdated
| @@ -1269,6 +1269,26 @@ describe('Event Factory', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| it('should create build for stage setup job, if startFrom is a stage name', () => { | |||
There was a problem hiding this comment.
Suggested change
| it('should create build for stage setup job, if startFrom is a stage name', () => { | |
| it('should create build for stage setup job, if startFrom is a job in the middle of a stage', () => { |
sagar1312
approved these changes
Aug 9, 2024
sagar1312
deleted the
hiftikhar01_feat_3413_replace_startFrom_to_stage_setup_if_it_is_a_middle_of_stage_job
branch
|
🎉 This PR is included in version 29.22.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently if the event is started from a job in the middle of the stage, the build for stage setup is not created
Objective
If the event is started from a job in the middle of the stage, the startFrom gets replaced to the setup job of the same stage
References
screwdriver-cd/screwdriver#3143
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.