Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(3272): Error while creating an event with a skip message #640

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

sagar1312
Copy link
Member

Context

After an event is created via SCM webhook with a skip message "[skip ci]", no builds are created.
In such scenario, the event itself is set as the builds on the event which is incorrect.

screwdriver-cd/screwdriver#3261 added a logic which iterates the builds that are created after the event to process the workflow for virtual builds. This new logic expects the builds set on the event to be either null or an array.

Due to the above mentioned incorrect the mapping, the new logic is failing with the below error

Error: Failed to start some events caused by \"event.builds.filter is not a function

Objective

After the event creation, when the builds are meant to be skipped, set null as the builds on the event.

References

screwdriver-cd/screwdriver#3272

License

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@VonnyJap VonnyJap merged commit 7eac5d7 into master Jan 28, 2025
2 checks passed
@VonnyJap VonnyJap deleted the sagar1312-fix-3272-skip_builds_error branch January 28, 2025 16:58
@sd-buildbot
Copy link

🎉 This PR is included in version 31.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants