fix(3143): skip jobs between stage setup and startFrom stage job only if they belong to the same stage #3166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThehamzaIftikhar
changed the title
ThehamzaIftikhar
changed the title
sagar1312
requested changes
Aug 7, 2024
plugins/builds/triggers/helpers.js
Outdated
| return isStageSetup(triggerJob) && !isStageSetup(startFrom) && isStageJob(workflowGraph, startFrom); | ||
| if (isStageSetup(triggerJob)) { | ||
| const startFromStageName = getStageName(workflowGraph, triggerJob); | ||
| const triggerStageName = getStageName(workflowGraph, triggerJob); |
There was a problem hiding this comment.
Suggested change
| const triggerStageName = getStageName(workflowGraph, triggerJob); | |
| const currentStageName = getStageName(workflowGraph, currentJobName); |
…ame stage for the startFrom job to be executed right after the current job
ThehamzaIftikhar
changed the title
sagar1312
approved these changes
Aug 8, 2024
sagar1312
deleted the
hiftikhar01_feat_3413_trigger_the_startFrom_job_after_stage_setup_if_event_started_from_middle_of_stage
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The isStartFromMiddleOfStage function does not check if the startFrom job and the stage setup belong to the same stage
Objective
the function will check that both the current job and startFrom belong to the same stage if the ortrigger is to be executed for this scenario
References
#3143
License
I confirm that this contribution is made under a BSD license and that I have the authority necessary to make this contribution on behalf of its copyright owner.