fix(3133): upstream event creation when restarting remote join from downstream build #3250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yk634
changed the title
y-oksaku
approved these changes
Dec 9, 2024
yakanechi
approved these changes
Dec 9, 2024
VonnyJap
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
A workflow containing a remote join may not trigger a build of the remote join if it is restarted from downstream.
Example
Build succeeds downstream and remote join build is triggered upstream.
Upstream remote join is not triggered even if build succeeds after restarting from downstream.
This is due to a unique constraint error when creating a subsequent remote join build after a successful build restarted from a downstream, when trying to create in the restart source upstream event.
Objective
In the remote join workflow, when restarted from a downstream, create a new event on the upstream side and create a build on that event.
References
#3133
License
I confirm that this contribution is made under a BSD license and that I have the authority necessary to make this contribution on behalf of its copyright owner.