Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add numpydoc validation hook and fix f-string syntax #546

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Add numpydoc validation hook and fix f-string syntax #546

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,11 @@
repos:
- repo: https://github.com/numpy/numpydoc
rev: v1.8.0
hooks:
- id: numpydoc-validation
files: ^src/
exclude: ^tests/

- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v4.5.0
hooks:
Expand Down
4 changes: 2 additions & 2 deletions src/scribe_data/load/send_dbs_to_scribe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,14 +81,14 @@
)
language_db_dict["translation"]["full_path_to_scribe_ios_db"] = (
PATH_TO_SCRIBE_DATA_ROOT.parent
/ f"{language_db_dict["translation"]['scribe_ios_db_path']}"
/ f"{language_db_dict['translation']['scribe_ios_db_path']}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch on these, @Ktyby21! Thanks for this :)

)
language_db_dict["translation"]["scribe_android_db_path"] = (
get_android_data_path() / "TranslationData.sqlite"
)
language_db_dict["translation"]["full_path_to_scribe_android_db"] = (
PATH_TO_SCRIBE_DATA_ROOT.parent
/ f"{language_db_dict["translation"]['scribe_android_db_path']}"
/ f"{language_db_dict['translation']['scribe_android_db_path']}"
)

for language in language_db_dict:
Expand Down
Loading