Adding a setLang option to the Client. #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarCloud Quality Gate failed.
|
Open
danmichaelo
force-pushed
the
master
branch
3 times, most recently
from
05ac47a to
dbb8592
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following issue #22 and having the same need, here is a PR that adds an option to set the lang in the client.
As I didn't want to change the parameters order in
__constructfor backward compatibility, I have just added a setLang function to the Client.And this time @danmichaelo I took time to learn a bit more about phpspec. It might not be the best tests ever, so feel free to update them before merging, I have never used this tool before one hour ago so it's mainly copy/paste.