Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #1790 on branch 0.11.x ((performance): speedup for zarr-based sparse indexing) #1801

Conversation

meeseeksmachine
Copy link
Contributor

Backport PR #1790: (performance): speedup for zarr-based sparse indexing

Copy link

scverse-benchmark bot commented Dec 10, 2024

Benchmark changes

Change Before [ba06d2a] After [2ab87c4] Ratio Benchmark (Parameter)
- 508±6ms 16.7±0.3ms 0.03 sparse_dataset.SparseCSRContiguousSlice.time_getitem((10000, 10000), ':9000:-1')
- 2.52±0.02s 75.0±2ms 0.03 sparse_dataset.SparseCSRContiguousSlice.time_getitem((10000, 10000), '::-2')
- 525±2ms 55.9±0.7ms 0.11 sparse_dataset.SparseCSRContiguousSlice.time_getitem((10000, 10000), 'alternating')
- 512±3ms 16.0±0.5ms 0.03 sparse_dataset.SparseCSRContiguousSlice.time_getitem((10000, 10000), 'arange')

Comparison: https://github.com/scverse/anndata/compare/ba06d2a905e7694bc84860f5768a20bfe2d16b46..2ab87c47c064e2dec5c43f263360efc365c3c891
Last changed: Tue, 10 Dec 2024 15:06:26 +0000

More details: https://github.com/scverse/anndata/pull/1801/checks?check_run_id=34199100320

@flying-sheep flying-sheep merged commit bd93c32 into scverse:0.11.x Dec 10, 2024
11 checks passed
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.57%. Comparing base (ba06d2a) to head (2ab87c4).
Report is 2 commits behind head on 0.11.x.

Additional details and impacted files
@@            Coverage Diff             @@
##           0.11.x    #1801      +/-   ##
==========================================
- Coverage   87.04%   84.57%   -2.47%     
==========================================
  Files          40       40              
  Lines        6089     6095       +6     
==========================================
- Hits         5300     5155     -145     
- Misses        789      940     +151     
Files with missing lines Coverage Δ
src/anndata/_core/sparse_dataset.py 93.63% <100.00%> (+0.12%) ⬆️

... and 8 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants