Expose random_state in leiden #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(leiden): expose additional parameter 1) expose 'random_state' parameter to better align with Scanpy 2) pass it to cuGraph via 'culeiden' 3) save its value in '.uns["leiden"]["params"]' 4) describe it in docstring 5) make multiple small improvements to docstring N.b., the 'theta' parameter was not exposed because a bug in cuGraph (present at commit 1e446c4) makes it have no effect; this should be re-visited when cuGraph is updated.
for more information, see https://pre-commit.ci
fix(leiden): fix undefined type Import 'Union' from 'typing' to fix error when defining 'random_state' (line 17)
Intron7
requested changes
Dec 12, 2023
Release note describing addition of `random_state` parameter to `leiden`
Include 0.9.4.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(leiden): expose additional parameter
random_stateparameter to better align with Scanpyculeiden.uns["leiden"]["params"]N.b., the
thetaparameter was not exposed because a bug in cuGraph (present at commit1e446c4) makes it have no effect; this should be re-visited when cuGraph is updated.Resolves first half of #101