Expose threshold in louvain #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(louvain): expose additional parameter 1) expose 'threshold' parameter (unavailable in Scanpy) 2) pass it to cuGraph via 'culouvain' 3) in 'culouvain' call, replace deprecated 'max_iter' with synonymous 'max_level' 4) save values of 'threshold' and 'n_iterations' (previously omitted) to '.uns["louvain"]["params"]' 5) add 'threshold' description to docstring and make multiple small improvements N.b. cuGraph does not provide a parameter to set the random state as of commit 1e446c4. Revisit if situation changes.
for more information, see https://pre-commit.ci
changed neighbors_key to str
Release note describing addition of `threshold` parameter to `louvain`
Include 0.9.4.md
Intron7
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(louvain): expose additional parameter
thresholdparameter (unavailable in Scanpy)culouvainculouvaincall, replace deprecatedmax_iterwith synonymousmax_levelthresholdandn_iterations(previously omitted) to.uns["louvain"]["params"]thresholddescription to docstring and make multiple small improvementsN.b. cuGraph does not provide a parameter to set the random state as of commit
1e446c4. Revisit if situation changes.Resolves second half of #101