-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for Multiple Color Formats in Hallway, Robot, Object and Location class. #307
Add Support for Multiple Color Formats in Hallway, Robot, Object and Location class. #307
Conversation
- Update the docstring to include `string` as an alternative type. - Change return type of `parse_color` from `list` to `tuple`. - Update test cases to reflect modified return type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome. Just 1 comment.
That's perfect -- thanks! That holds for all the docstrings of the modified classes in this PR too, of course. |
You may also need to update the expected error message in the test |
I wanted to highlight one thing. While using the Docker setup you provided for local development, I noticed that the I think it would be helpful to mount it as a volume. This way, contributors (like me) can |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I'll take a look at making docs build possible in the docker. Good idea.
This update allows the
Hallway
,Robot
,Object
andLocation
class to accept the color parameter in multiple formats:Unit tests have been modified wherever needed.