Fix Ruby formatter #452
Fix Ruby formatter #452
Conversation
| @@ -69,7 +69,18 @@ seam.acs.access_groups.get(acs_access_group_id: "44444444-4444-4444-4444-4444444 | |||
| #### Response | |||
|
|
|||
| ```ruby | |||
| {"acs_access_group_id" => "44444444-4444-4444-4444-444444444444", "name" => "Lobby Access", "display_name" => "Lobby Access", "access_group_type_display_name" => "PTI access level", "access_group_type" => "pti_access_level", "external_type" => "pti_access_level", "external_type_display_name" => "PTI access level", "acs_system_id" => "11111111-1111-1111-1111-111111111111", "workspace_id" => "00000000-0000-0000-0000-000000000000", "created_at" => "2023-11-30T06:27:15.437Z"} | |||
| { | |||
| "acs_access_group_id" => "44444444-4444-4444-4444-444444444444", | |||
There was a problem hiding this comment.
@andrii-balitskyi When I use a GitHub codespace to run Ruby, I don't think I see "=>" in the responses. I also don't think I see commas separating the prop-value pairs in the responses. Does that matter?
There was a problem hiding this comment.
I think it's ok. @razor-x and I agreed on using the hash arrow syntax for Ruby responses, similar to JSON.
|
@andrii-balitskyi Are we no longer using standard? If so, we need to remove or update the references:
|
|
@razor-x yes, if using prettier works for you. I tried using stanardrb to format the code samples as needed, but I ran into some setup issues that were taking too long to resolve. Instead, I found a Ruby plugin (which requires ruby and syntax_tree dependencies as well) for prettier that's much more straightforward to implement. I'll update the README and devcontainer accordingly. |
Co-authored-by: Evan Sosenko <[email protected]>
|
@razor-x Why does devcontainer need to install ruby formatter? I don't see it installing prettier, for example. |
The devcontainer installs prettier as part of The devcontainer should have a full development env so it needs each formatter installed. |
Closes #401