Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format child prop names as code and fix details line spacing #469

Merged
merged 5 commits into from
Dec 19, 2024

Conversation

DebbieAtSeam
Copy link
Contributor

@DebbieAtSeam DebbieAtSeam commented Dec 18, 2024

@andrii-balitskyi and @razor-x Could I please suggest that we format prop names within prop child objects as code?

I don't love that we end up with two separate bits, both formatted as code, right next to each other, so another option would be to add "Format: " before the second bit. I'll add a suggestion in a comment to see what you think.

Committed it. Please let me know if you don't like the "Format: " thing.
Thanks!

@DebbieAtSeam DebbieAtSeam changed the title Format child prop names as code Format child prop names as code and fix details line spacing Dec 18, 2024
@DebbieAtSeam DebbieAtSeam merged commit 6a4942e into main Dec 19, 2024
13 checks passed
@DebbieAtSeam DebbieAtSeam deleted the format-child-prop-names branch December 19, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants