Adds overlapRasterGroupMetrics function #270
Conversation
| /** Raster to overlap, keyed by class ID, use empty array if overlapArea operation */ | ||
| featuresByClass: Record<string, Georaster>; |
There was a problem hiding this comment.
Should this extra part of comment be dropped? "use empty array if overlapArea operation". Maybe it was copied over from the other function.
There was a problem hiding this comment.
Removing that last part, it was an artifact as you expected
| featuresByClass: | ||
| | Record<string, Feature<Polygon>[]> | ||
| | Record<string, Georaster>; |
There was a problem hiding this comment.
My understanding is that overlapGroupMetrics can now be called with either features or a raster. That seems to be the main reason to have mixed mixed vector and raster into the same typings? If so, would you be willing to write a test that this function can now handle either input?
There was a problem hiding this comment.
That is the case, yeah. I did keep the name the same and added the extra typing so there wouldn't be a breaking change. It's handling of raster input is tested in overlapGroupMetrics.test.ts, and I can add a test of the feature[] input.
* Adds overlapRasterGroupMetrics function * Tests overlapGroupMetrics can recieve feature[]
Functions calculating "grouped" metrics exist in the gp library for overlapFeatures and overlapArea, but not for raster overlap analysis.
Adds a corresponding
overlapRasterGroupMetricsfunction to go along with theoverlapAreaGroupMetricsandoverlapFeaturesGroupMetricsfunctions, bringing this functionality from in-project code in the Belize reports.Experimental release
6.1.3-experimental-rasterGroupMetrics.0was tested in the Belize reports and confirmed working.