Keys are also already decoded by URLSearchParams

seasonedcc · Nov 1, 2023 · fc2cb44 · fc2cb44
1 parent 9e4c02b
commit fc2cb44
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/input-resolvers.test.ts b/src/input-resolvers.test.ts
@@ -255,8 +255,8 @@ describe('inputFromSearch', () => {
 
   it('takes keys encoded as URI components', () => {
     const qs = new URLSearchParams()
-    qs.append('some%20colors[0]', 'blue')
-    qs.append('some%20colors[1]', 'red ish')
+    qs.append('some colors[0]', 'blue')
+    qs.append('some colors[1]', 'red ish')
     assertEquals(subject.inputFromSearch(qs), {
       'some colors': ['blue', 'red ish'],
     })

diff --git a/src/input-resolvers.ts b/src/input-resolvers.ts
@@ -28,8 +28,7 @@ const inputFromSearch = (queryString: URLSearchParams) => {
 
   return pairs
     .sort(([keyA], [keyB]) => keyA.localeCompare(keyB))
-    .reduce((parsed, [encodedKey, value]) => {
-      const key = decodeURIComponent(encodedKey)
+    .reduce((parsed, [key, value]) => {
       const compositeKey = key.match(/([^\[\]]*)(\[.*\].*)$/)
       if (compositeKey) {
         const [, rootKey, subKeys] = compositeKey