Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apply schema #148

Merged
merged 8 commits into from
Jun 11, 2024
Merged

apply schema #148

merged 8 commits into from
Jun 11, 2024

Conversation

diogob
Copy link
Contributor

@diogob diogob commented Jun 7, 2024 •
edited
Loading

We should not allow applySchema to take schemas that would potentially break our runtime with a wider type than what the composable takes.

@diogob diogob marked this pull request as ready for review June 7, 2024 19:08
gustavoguichard
gustavoguichard reviewed Jun 7, 2024
View reviewed changes
Copy link
Collaborator

@gustavoguichard gustavoguichard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll need to update the arktype example before merging it

@gustavoguichard gustavoguichard merged commit 1a0f5e7 into main Jun 11, 2024
1 check passed
@gustavoguichard gustavoguichard deleted the apply-schema branch June 11, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gustavoguichard gustavoguichard gustavoguichard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diogob @gustavoguichard