Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API adjustment for the STT yielding class to improve friendliness with Ride #14

Conversation

sebastianconcept
Copy link
Owner

Makes the STT API more consistent with the render:using: and renderUsing: methods seen in Ride's renderer based on STTemplate.

With this change, developers won't need to remember 2 sets of rules for the yield method when used from Ride.

So now this is possible:

<st STT yieldUsing: 'shared/feedback.html' >
<div class="container">
	<h1>Post</h1>
	<st= self render: model>
	<div>
	...

@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e2a3df4) 94.32% compared to head (a04bca9) 97.00%.
Report is 8 commits behind head on master.

❗ Current head a04bca9 differs from pull request most recent head 5b4eb82. Consider uploading reports for the commit 5b4eb82 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
+ Coverage   94.32%   97.00%   +2.68%     
==========================================
  Files           5        5              
  Lines        1498     1503       +5     
==========================================
+ Hits         1413     1458      +45     
+ Misses         85       45      -40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sebastianconcept sebastianconcept self-assigned this Feb 6, 2024
@sebastianconcept sebastianconcept merged commit c7d1ca9 into master Feb 18, 2024
1 check passed
@sebastianconcept sebastianconcept deleted the 13-API-for-STT-yield-needs-to-be-adjusted-for-consistency branch February 18, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants